Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chirp - reuse the version number #5331

Merged
merged 1 commit into from
Jul 15, 2014
Merged

Chirp - reuse the version number #5331

merged 1 commit into from
Jul 15, 2014

Conversation

radeksimko
Copy link
Contributor

No description provided.

@vitorgalvao
Copy link
Member

Why the change? Was something broken?

@radeksimko
Copy link
Contributor Author

I've just seen a PR adding this new cask and I thought this would make it easier to maintain and more readable for the future.

This is similar change: f0b8544 although I understand I'm not changing the lines order.

@vitorgalvao
Copy link
Member

Oh, right. Apologies, I was seeing it in reverse. Ideally they’ll all be like this. I looked at the PR and my brain though you were removing #{version} for the number, as opposed to the other way around.

@rolandwalker
Copy link
Contributor

Thanks @radeksimko .

rolandwalker added a commit that referenced this pull request Jul 15, 2014
Chirp - reuse the version number
@rolandwalker rolandwalker merged commit b921e40 into Homebrew:master Jul 15, 2014
@radeksimko radeksimko deleted the chirp branch July 15, 2014 06:25
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants